Github user jyates commented on a diff in the pull request:

    https://github.com/apache/phoenix/pull/15#discussion_r17636489
  
    --- Diff: 
phoenix-core/src/main/java/org/apache/phoenix/trace/util/Tracing.java ---
    @@ -43,6 +47,8 @@
     import org.cloudera.htrace.wrappers.TraceRunnable;
     
     import com.google.common.base.Function;
    +import com.google.common.base.Preconditions;
    +import com.sun.istack.NotNull;
    --- End diff --
    
    i think if you mark something as not null, you don't need to do the null 
check - kind of the deal with programming by contract, ya?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to