Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/12#discussion_r17756887
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/iterate/DefaultParallelIteratorRegionSplitter.java
---
@@ -117,121 +107,87 @@ public boolean apply(HRegionLocation location) {
}
protected List<KeyRange> genKeyRanges(List<HRegionLocation> regions) {
- if (regions.isEmpty()) {
- return Collections.emptyList();
+ if (regions.isEmpty()) { return Collections.emptyList(); }
+ Scan scan = context.getScan();
+ PTable table = this.tableRef.getTable();
+ byte[] defaultCF = SchemaUtil.getEmptyColumnFamily(table);
+ List<byte[]> gps = null;
--- End diff --
Initialize gps to an empty list here instead and ensure your PTable and
PColumnFamily methods don't return null, but empty list instead if there are no
guideposts. That way you don't have to check for null everywhere and can get
rid of the extra if statement below.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
