[ 
https://issues.apache.org/jira/browse/PHOENIX-1273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14145339#comment-14145339
 ] 

James Taylor commented on PHOENIX-1273:
---------------------------------------

Also, my read/write methods for LikeExpression aren't correct - the likeType 
needs to always be serialized. FYI, the client-side evaluation will go through 
the one arg constructor, but we push these expressions through our custom 
filter where the readFields is used to reestablish the object.
{code}
    @Override
    public void readFields(DataInput input) throws IOException {
        super.readFields(input);
        try {
            likeType = LikeType.values()[WritableUtils.readVInt(input)];
        } catch (EOFException e) {
            likeType = LikeType.CASE_SENSITIVE;
        }
        init();
    }

    @Override
    public void write(DataOutput output) throws IOException {
        super.write(output);
        WritableUtils.writeVInt(output, likeType.ordinal());
    }
{code}


> Phoenix should provide ILIKE keyword
> ------------------------------------
>
>                 Key: PHOENIX-1273
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-1273
>             Project: Phoenix
>          Issue Type: Bug
>    Affects Versions: 4.2
>            Reporter: Jean-Marc Spaggiari
>            Assignee: Jean-Marc Spaggiari
>            Priority: Minor
>         Attachments: PHOENIX-1273-v1.patch, PHOENIX-1273-v2.patch, 
> PHOENIX-1273-v3.patch, PHOENIX-1273.patch
>
>
> Phoenix provides LIKE keyword but not ILIKE which is a case insensitive LIKE. 
> Goal of this patch is to add this keyword.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to