[
https://issues.apache.org/jira/browse/PHOENIX-1264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14153674#comment-14153674
]
James Taylor edited comment on PHOENIX-1264 at 9/30/14 8:03 PM:
----------------------------------------------------------------
Patch looks good, [~ramkrishna]. +1. One change that really should go with
PHOENIX-1263, is this one:
{code}
- PTableStats stats = updateStatsInternal(physicalTableName.getBytes(),
columns);
+ PTableStats stats = tenantId == null ?
updateStatsInternal(physicalTableName.getBytes(), columns) : null;
{code}
but I'm fine if you want to leave that in - just we aware that you'll need to
make this change on the 4.0 and master branch when you get back to PHOENIX-1263.
Also, please file a JIRA for the default property in QueryServicesTestImpl not
taking effect in 3.0, as that's a problem.
was (Author: jamestaylor):
Patch looks good, [~ramkrishna]. +1. One change that really should go with
PHOENIX-1263, is this one:
- PTableStats stats = updateStatsInternal(physicalTableName.getBytes(),
columns);
+ PTableStats stats = tenantId == null ?
updateStatsInternal(physicalTableName.getBytes(), columns) : null;
but I'm fine if you want to leave that in - just we aware that you'll need to
make this change on the 4.0 and master branch when you get back to PHOENIX-1263.
Also, please file a JIRA for the default property in QueryServicesTestImpl not
taking effect in 3.0, as that's a problem.
> Add StatisticsCollector to existing tables on first connection to cluster
> -------------------------------------------------------------------------
>
> Key: PHOENIX-1264
> URL: https://issues.apache.org/jira/browse/PHOENIX-1264
> Project: Phoenix
> Issue Type: Sub-task
> Reporter: James Taylor
> Assignee: ramkrishna.s.vasudevan
> Attachments: Pheonix-1264_3.0.patch, Pheonix-1264_3.0_1.patch,
> Phoenix-1264_1.patch, Phoenix-1264_2.patch, Phoenix-1264_3.0_1.patch,
> Phoenix-1264_3.0_3.patch, Phoenix-1264_3.patch
>
>
> We'll need to add the StatisticsCollector to existing tables so that stats
> are kept for these tables. We typically do that on first connection to the
> cluster in ensureTableCreated when our system table is created by walking
> through the existing Phoenix tables. We only need to do it if the system
> table already exists (otherwise, it's a new installation).
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
