[
https://issues.apache.org/jira/browse/PHOENIX-1263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14154423#comment-14154423
]
James Taylor commented on PHOENIX-1263:
---------------------------------------
Thanks for the patch, [~ramkrishna]. Yes, the updateCache call in
MetaDataClient isn't necessary. Also, for the call to clearCacheForTable, make
sure you're using null for tenantId, and use the physicalName to get both the
schemaName and tableName.
{code}
connection.getQueryServices().clearCacheForTable(null,
SchemaUtil.getSchemaNameFromFullName(physicalName.getString()),
SchemaUtil.getTableNameFromFullName(physicalName.getString()),
clientTS);
{code}
+1 after these changes and all unit tests passing.
> Only cache guideposts on physical PTable
> ----------------------------------------
>
> Key: PHOENIX-1263
> URL: https://issues.apache.org/jira/browse/PHOENIX-1263
> Project: Phoenix
> Issue Type: Sub-task
> Reporter: James Taylor
> Assignee: ramkrishna.s.vasudevan
> Attachments: Phoenix-1263_1.patch, Phoenix-1263_6.patch,
> Phoenix-1263_7.patch
>
>
> Rather than caching the guideposts on all tenant-specific tables, we should
> cache them only on the physical table. On the client side, we should also
> update the cache with the latest for the base multi-tenant table when we
> update the cache for a tenant-specific table. Then when we lookup the
> guideposts, we should ensure that we're getting them from the physical table.
> Otherwise, it'll be difficult to keep the guideposts cached on the PTable in
> sync across all tenant-specific tables (not to mention using quite a bit of
> memory).
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
