[ 
https://issues.apache.org/jira/browse/PHOENIX-1314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14168237#comment-14168237
 ] 

James Taylor commented on PHOENIX-1314:
---------------------------------------

Thanks for the patch, [~rajesh23]. Yes, this fixes that issue. The assertion is 
testing that the skip scan is always moving forward. It'd be a bug in the skip 
scan filter otherwise. It's only testing the hint against the next one for the 
skip scan filter - it wouldn't be affected by what other filters are doing. I'd 
prefer leaving the assert in, especially in 3.0 where this can lead to an 
infinite loop (looks like 0.98 prevents this in some way, though).

> Assertion tripped for skip scan with two unit tests
> ---------------------------------------------------
>
>                 Key: PHOENIX-1314
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-1314
>             Project: Phoenix
>          Issue Type: Bug
>    Affects Versions: 4.1
>            Reporter: James Taylor
>            Assignee: rajeshbabu
>         Attachments: PHOENIX-1314.patch
>
>
> After checking in a pretty sizeable change 
> (https://git-wip-us.apache.org/repos/asf?p=phoenix.git;a=commit;h=d018cc1c6e01d9836de6e67af4f8b91de3269bfd),
>  the assert in SkipScanFilter.setNextCellHint() started getting tripped for 
> the following unit tests: 
> - DeleteIT.testDeleteAllFromTableWithIndexNoAutoCommitNoSalting()
> - MutableIndexIT.testCoveredColumnUpdatesWithLocalIndex()
> The tests seem to pass without this assert (not sure what HBase does if the 
> seek next hint is the same as the current row), but it would be good to get 
> to the bottom of this. Would you mind taking a look, [~rajesh23]? It's 
> possibly related to PHOENIX-1313.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to