[
https://issues.apache.org/jira/browse/PHOENIX-1297?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Samarth Jain updated PHOENIX-1297:
----------------------------------
Attachment: PHOENIX-1297_v5.patch
[~jamestaylor]
Attached is the updated patch.
Overview of the more significant changes:
1) Added encodeValues and decodeValues methods in PhoenixRuntime. Removed the
old encodePK and decodePK methods. The new methods now use KeyValueSchema to
encode and decode column values.
2) Added methods to look up column given a column family and column name.
3) Fixed a bug in KeyValueSchema where it was not assigning the the isNullable
flag for fields correctly. Added a test in ValueBitSetTest to verify the same.
4) Fixed a test bug in ArrayIT.
5) Tried making the change for array types in PDataType.java. But it didn't
work out . Reason being Java enum constructors are called before static blocks
are initialized. So the map to look up sql type name isn't initialized.
6) Added tests in QueryOptimizerTest to verify the query plan.
7) Added tests in PhoenixruntimeTest to make sure roundtripping of sql type
names returned by the newly added method PhoenixRuntime#getPkColsDataTypes
works.
Please review. Thanks!
> Adding utility methods to get primary key information from the optimized
> query plan
> -----------------------------------------------------------------------------------
>
> Key: PHOENIX-1297
> URL: https://issues.apache.org/jira/browse/PHOENIX-1297
> Project: Phoenix
> Issue Type: Task
> Affects Versions: 5.0.0, 4.2, 3.2
> Reporter: Samarth Jain
> Assignee: Samarth Jain
> Attachments: PHOENIX-1297.patch, PHOENIX-1297_v2.patch,
> PHOENIX-1297_v3.patch, PHOENIX-1297_v4.patch, PHOENIX-1297_v5.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
