[
https://issues.apache.org/jira/browse/PHOENIX-1356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14176326#comment-14176326
]
rajeshbabu commented on PHOENIX-1356:
-------------------------------------
[~aliciashu]
I agree with first point.
bq. The test may waiting longer than necessary inside the loop (regionNumber
!= 4+i)
Yes we loop until parent region info removed by CTJ. That's why setting
hbase.catalogjanitor.interval to smaller value 5sec so it will comeout from
loop as soon as parent region info removed from meta which will not take much
time.
bq. MetaReader is private. Better not calling it directly.
It's public method only not private.
{code}
* Gets all of the regions of the specified table.
* @param catalogTracker
* @param tableName
* @param excludeOfflinedSplitParents If true, do not include offlined split
* parents in the return.
* @return Ordered list of {@link HRegionInfo}.
* @throws IOException
*/
public static List<HRegionInfo> getTableRegions(CatalogTracker catalogTracker,
TableName tableName, final boolean excludeOfflinedSplitParents)
{code}
Any way it's ok for me to commit your patch also if you feel it's not
convincing.
Thanks.
> LocalIndexIT.testLocalIndexScanAfterRegionSplit() failed at distributed
> cluster when getting regions
> ----------------------------------------------------------------------------------------------------
>
> Key: PHOENIX-1356
> URL: https://issues.apache.org/jira/browse/PHOENIX-1356
> Project: Phoenix
> Issue Type: Bug
> Reporter: Alicia Ying Shu
> Assignee: Alicia Ying Shu
> Fix For: 5.0.0, 4.2
>
> Attachments: PHOENIX-1356-4.0.patch, PHOENIX-1356.patch
>
>
> testLocalIndexScanAfterRegionSplit can raise exception when running in
> distributed mode :
> testLocalIndexScanAfterRegionSplit(org.apache.phoenix.end2end.index.LocalIndexIT)
> MainThread|java.lang.RuntimeException:
> org.apache.hadoop.hbase.DistributedHBaseCluster@f497380 not an instance of
> org.apache.hadoop.hbase.MiniHBaseCluster
> org.apache.hadoop.hbase.HBaseTestingUtility.getMiniHBaseCluster(HBaseTestingUtility.java:938)
> org.apache.hadoop.hbase.HBaseTestingUtility.getHBaseCluster(HBaseTestingUtility.java:2500)
> org.apache.phoenix.end2end.index.LocalIndexIT.testLocalIndexScanAfterRegionSplit(LocalIndexIT.java:627)
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
