[ 
https://issues.apache.org/jira/browse/PHOENIX-1355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14176495#comment-14176495
 ] 

James Taylor commented on PHOENIX-1355:
---------------------------------------

[~jeffreyz] - since we'd like to cut the RC tomorrow AM, would you mind 
checking this in? Mujtaba can review and recommend any changes Monday. One 
thing to keep in mind (and I don't know exactly how Mujtaba manages this), the 
script needs to work both when run from a local build in a dev environment as 
well as in our binary releases (where the directory structure is different). 
Does your patch handle this?

> sqlline.py or psql.py may hang if they're not invoked from bin folder
> ---------------------------------------------------------------------
>
>                 Key: PHOENIX-1355
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-1355
>             Project: Phoenix
>          Issue Type: Bug
>    Affects Versions: 4.1
>            Reporter: Jeffrey Zhong
>            Assignee: Jeffrey Zhong
>         Attachments: PHOENIX-1355.patch
>
>
> In the phoenix_utils.py, we have following code which searching for client 
> jar. If a user invokes sqlline or psql from a root folder, this step will 
> take a while.
> {code}
>   if phoenix_client_jar == "":
>     phoenix_client_jar = find("phoenix-*-client*", os.path.join(current_dir, 
> ".."))
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to