[ 
https://issues.apache.org/jira/browse/PHOENIX-1322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14176593#comment-14176593
 ] 

James Taylor edited comment on PHOENIX-1322 at 10/20/14 4:16 AM:
-----------------------------------------------------------------

Thanks for the patch, [~ramkrishna]. Here's some feedback:
Please put this as the first item in the recent.md list and add a "1." in front 
of it so it's rendered correctly:
+1. **[Collect Statistics](update_statistics.html)**. Collects the statistics 
for a table to improve query parallelization.** Available in our 3.2/4.2 
release**

Slight tweak here so that language is consistent with other items, use link to 
new stats collection page, and correct typo:
+15. **[Cost-based Query 
Optimization]((https://issues.apache.org/jira/browse/PHOENIX-1177))**. With 
[statistics collection](update_statistics.html) in place, improve statistics 
collection to enable further query optimizations based on the size and 
cardinality of the data.

Surround names with <code> tag:
+For a given table named <code>my_table</code>:

For update_statistics.md, add a description at the end for 
phoenix.stats.updateFrequency:
4. phoenix.stats.updateFrequency
    * Minimum frequency in milliseconds that new statistics will be
checked for when pulling over new metadata from the client to the
server.






was (Author: jamestaylor):
Thanks for the patch, [~ramkrishna]. Here's some feedback:
Please put this as the first item in the recent.md list and add a "1." in front 
of it so it's rendered correctly:
+1. **[Collect Statistics](update_statistics.html)**. Collects the statistics 
for a table to improve query parallelization.** Available in our 3.2/4.2 
release**

Slight tweak here so that language is consistent with other items, use link to 
new stats collection page, and correct typo:
+15. **[Cost-based Query 
Optimization]((https://issues.apache.org/jira/browse/PHOENIX-1177))**. With 
[statistics collection](update_statistics.md) in place, improve statistics 
collection to enable further query optimizations based on the size and 
cardinality of the data.

Surround names with <code> tag:
+For a given table named <code>my_table</code>:

For update_statistics.md, add a description at the end for 
phoenix.stats.updateFrequency:
4. phoenix.stats.updateFrequency
    * Minimum frequency in milliseconds that new statistics will be
checked for when pulling over new metadata from the client to the
server.





> Add documentation for UPDATE STATISTICS command
> -----------------------------------------------
>
>                 Key: PHOENIX-1322
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-1322
>             Project: Phoenix
>          Issue Type: Sub-task
>            Reporter: James Taylor
>            Assignee: ramkrishna.s.vasudevan
>         Attachments: Phoenix-1322_1.patch
>
>
> Four places need to be updated:
> - Add a new webpage and add the webpage to the Using menu 
> (/site/source/src/site/site.xml). The webpage can talk about the new ANALYZE 
> <table> command and give a couple of examples. It'd be good to document that 
> stats are updated automatically during splits and compaction. Also, mention 
> the new property values you added to control - number of bytes before 
> guidepost put in, min time before another analyze may be done. Don't talk 
> about implementation, though, other than the "why" we're doing this (i.e. to 
> improve parallelization).
> - Add the new ANALYZE call with a short explanation to 
> ./phoenix-docs/src/docsrc/help/phoenix.csv. This will cause it to appear 
> here: http://phoenix.apache.org/language/index.html
> - Add an item at the top for Statistics Collection with a short explanation 
> here: site/source/src/site/markdown/recent.md
> - Remove the first item from Cost-based Query Optimization, or change the 
> font to strike through with a note that it's implemented in 3.2/4.2) here: 
> site/source/src/site/markdown/roadmap.md



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to