[
https://issues.apache.org/jira/browse/PHOENIX-1364?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14178770#comment-14178770
]
James Taylor commented on PHOENIX-1364:
---------------------------------------
Yep, I agree it's better practice to close the statements. I'm trying to
minimize the changes right now so we can get the RC cut today, though. BTW,
this fixes PHOENIX-1371 which is a big improvement. Thanks for the
contributions, [~tedyu].
> Fix resource leaks in various classes
> -------------------------------------
>
> Key: PHOENIX-1364
> URL: https://issues.apache.org/jira/browse/PHOENIX-1364
> Project: Phoenix
> Issue Type: Bug
> Reporter: Ted Yu
> Assignee: Ted Yu
> Attachments: 1364-v2.txt, 1364-v3.patch, fix-resource-leak-v1.txt
>
>
> Statement / PreparedStatement should be closed after query completes.
> Below is an example of resource leak from
> MetaDataUtil#deleteViewIndexSequences():
> {code}
> public static void deleteViewIndexSequences(PhoenixConnection
> connection, PName name) throws SQLException {
> SequenceKey key = getViewIndexSequenceKey(null, name);
> connection.createStatement().executeUpdate("DELETE FROM " +
> PhoenixDatabaseMetaData.SEQUENCE_TABLE_NAME +
> {code}
> The Statement created by connection.createStatement() should be closed upon
> return.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
