[
https://issues.apache.org/jira/browse/PHOENIX-1364?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ted Yu updated PHOENIX-1364:
----------------------------
Description:
Initially the patch tried to achieve this:
Statement / PreparedStatement should be closed after query completes.
Later the scope was narrowed to closing tracing scope to stop excessive traces.
was:
Statement / PreparedStatement should be closed after query completes.
Below is an example of resource leak from
MetaDataUtil#deleteViewIndexSequences():
{code}
public static void deleteViewIndexSequences(PhoenixConnection connection,
PName name) throws SQLException {
SequenceKey key = getViewIndexSequenceKey(null, name);
connection.createStatement().executeUpdate("DELETE FROM " +
PhoenixDatabaseMetaData.SEQUENCE_TABLE_NAME +
{code}
The Statement created by connection.createStatement() should be closed upon
return.
> Close tracing scope to stop excessive tracing
> ---------------------------------------------
>
> Key: PHOENIX-1364
> URL: https://issues.apache.org/jira/browse/PHOENIX-1364
> Project: Phoenix
> Issue Type: Bug
> Reporter: Ted Yu
> Assignee: Ted Yu
> Fix For: 5.0.0, 4.2
>
> Attachments: 1364-v2.txt, 1364-v3.patch, 1364-v4.patch,
> fix-resource-leak-v1.txt
>
>
> Initially the patch tried to achieve this:
> Statement / PreparedStatement should be closed after query completes.
> Later the scope was narrowed to closing tracing scope to stop excessive
> traces.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
