[
https://issues.apache.org/jira/browse/PHOENIX-910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14182345#comment-14182345
]
Anoop Sam John commented on PHOENIX-910:
----------------------------------------
I will commit James.
> Filter should override hasFilterRow() when filterRow() is overridden
> --------------------------------------------------------------------
>
> Key: PHOENIX-910
> URL: https://issues.apache.org/jira/browse/PHOENIX-910
> Project: Phoenix
> Issue Type: Task
> Reporter: Ted Yu
> Assignee: Ted Yu
> Attachments: 910-v1.txt, 910-v2.txt
>
>
> There're 3 Filters where filterRow() is overridden but hasFilterRow() is not:
> {code}
> public boolean filterRow() {
> ./phoenix-core/src/main/java/org/apache/phoenix/filter/MultiKeyValueComparisonFilter.java
> public boolean filterRow() {
> ./phoenix-core/src/main/java/org/apache/phoenix/filter/RowKeyComparisonFilter.java
> public boolean filterRow() {
> ./phoenix-core/src/main/java/org/apache/phoenix/filter/SingleKeyValueComparisonFilter.java
> {code}
> hasFilterRow() should be overridden and return true.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
