[ 
https://issues.apache.org/jira/browse/PHOENIX-1396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14198793#comment-14198793
 ] 

Hudson commented on PHOENIX-1396:
---------------------------------

SUCCESS: Integrated in Phoenix-master #473 (See 
[https://builds.apache.org/job/Phoenix-master/473/])
PHOENIX-1396: Avoid unnecessary ResultSpooler.bin files creation/deletion every 
time SpoolingResultIterator is used (jeffreyz: rev 
237c55614133f9317e7171b329ca7b966c0c28ff)
* 
phoenix-core/src/main/java/org/apache/phoenix/iterate/SpoolingResultIterator.java


> Avoid unnecessary ResultSpooler.bin files creation/deletion every time 
> SpoolingResultIterator is used 
> ------------------------------------------------------------------------------------------------------
>
>                 Key: PHOENIX-1396
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-1396
>             Project: Phoenix
>          Issue Type: Bug
>    Affects Versions: 4.0.0
>            Reporter: Jeffrey Zhong
>            Assignee: Jeffrey Zhong
>             Fix For: 5.0.0, 4.3, 3.3, 4.2.1
>
>         Attachments: PHOENIX-1396-v2.patch, PHOENIX-1396.patch
>
>
> In SpoolingResultIterator.java, we have following code:
> {code}
>             tempFile = File.createTempFile("ResultSpooler",".bin", new 
> File(spoolDirectory));
>             DeferredFileOutputStream spoolTo = new 
> DeferredFileOutputStream(size, tempFile) {
> {code}
> Basically we pre-create spill file even we don't reach memory threshold and 
> later we delete the same file if it's not needed in finally block. We can 
> remove these unnecessary file creation & deletion altogether.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to