[ 
https://issues.apache.org/jira/browse/PHOENIX-1407?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Gabriel Reid updated PHOENIX-1407:
----------------------------------
    Attachment: PHOENIX-1407.patch

Hopefully this still counts as "today" for you [~giacomotaylor]. 

Here's a patch which seems to do the job. The setting on the scan is actually 
done in the constructor of QueryCompiler in the patch -- do you see any 
problems with that?

I put some tests into WhereCompilerTest as you suggested, and also noticed that 
the scan caching wasn't being set anywhere at all. I suppose this means that 
whatever is set in the hbase-site.xml was being used as far as caching, or 
maybe even no caching at all on scans?

> PhoenixStatement.getFetchSize() appears to never be used
> --------------------------------------------------------
>
>                 Key: PHOENIX-1407
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-1407
>             Project: Phoenix
>          Issue Type: Bug
>            Reporter: James Taylor
>            Assignee: Gabriel Reid
>         Attachments: PHOENIX-1407.patch
>
>
> We should use PhoenixStatement.getFetchSize() or potentially 
> PhoenixResultSet.getFetchSize() to determine what to use for 
> Scan.setCaching(). I'm not seeing this done currently, but maybe I'm just 
> missing it.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to