[
https://issues.apache.org/jira/browse/PHOENIX-1407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14202233#comment-14202233
]
James Taylor commented on PHOENIX-1407:
---------------------------------------
+1. Looks great, [~gabriel.reid]. Thanks for the quick turnaround. Doing it in
the constructor is fine.
The scanner caching is set in QueryServicesOptions to 1000 (i.e.
QueryServicesOptions.DEFAULT_SCAN_CACHE_SIZE), but it would not have been
overridden by the Statement fetch size.
Please commit to 3.0, 3.2, 4.0, 4.2, and master.
> PhoenixStatement.getFetchSize() appears to never be used
> --------------------------------------------------------
>
> Key: PHOENIX-1407
> URL: https://issues.apache.org/jira/browse/PHOENIX-1407
> Project: Phoenix
> Issue Type: Bug
> Reporter: James Taylor
> Assignee: Gabriel Reid
> Attachments: PHOENIX-1407.patch
>
>
> We should use PhoenixStatement.getFetchSize() or potentially
> PhoenixResultSet.getFetchSize() to determine what to use for
> Scan.setCaching(). I'm not seeing this done currently, but maybe I'm just
> missing it.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
