[
https://issues.apache.org/jira/browse/PHOENIX-1453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14219114#comment-14219114
]
James Taylor commented on PHOENIX-1453:
---------------------------------------
Nice work and great turn around on the patch, [~ramkrishna]. Here's some
feedback:
- Storing GUIDE_POST_ROW_COUNT as a BIGINT ARRAY, parallel to GUIDE_POSTS will
give us the most flexibility. That way, on the client side, we can calculate
per guidepost how many rows will be traversed.
- For the backward compatibility, we'll want to dynamically add the new
SYSTEM.STATS column in the TableNotFoundException in
ConnectionQueryServicesImpl.init() method. You'll want to call
ConnectionQueryServicesImpl.addColumnsIfNotExists() for the new column - see
prior Phoenix init() methods for an example. You'll also want to bump up the
MetaDataProtocol.MIN_SYSTEM_TABLE_TIMESTAMP, as that what causes the
TableNotFoundException versus NewerTableFoundException to be called.
- Need some unit tests around this.
Thanks!
> Collect row counts per region in stats table
> --------------------------------------------
>
> Key: PHOENIX-1453
> URL: https://issues.apache.org/jira/browse/PHOENIX-1453
> Project: Phoenix
> Issue Type: Sub-task
> Reporter: James Taylor
> Assignee: ramkrishna.s.vasudevan
> Attachments: Phoenix-1453.patch
>
>
> We currently collect guideposts per equal chunk, but we should also capture
> row counts. Should we have a parallel array with the guideposts that count
> rows per guidepost, or is it enough to have a per region count?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
