[
https://issues.apache.org/jira/browse/PHOENIX-1408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14225633#comment-14225633
]
James Taylor commented on PHOENIX-1408:
---------------------------------------
+1 with one minor tweak that I'll make at commit time - there's no need to
declare the throw of TableNotFoundException in the method signatures, as it's
derived from IOException which is already declared.
Thanks for fixing the handling of InterruptedException. Would you mind filing a
separate JIRA and fixing this up elsewhere in the code, [~samarthjain]?
I'll commit to master and 4.0 and then commit the required part for
PHOENIX-1473 to 4.2.
> Don't disable table before modifying HTable metadata
> ----------------------------------------------------
>
> Key: PHOENIX-1408
> URL: https://issues.apache.org/jira/browse/PHOENIX-1408
> Project: Phoenix
> Issue Type: Bug
> Reporter: James Taylor
> Assignee: Samarth Jain
> Attachments: PHOENIX-1408.patch, PHOENIX-1408_v2.patch,
> PHOENIX-1408_v3.patch
>
>
> In 0.98, HBase supports modifying the HTable metadata without disabling the
> table first. We should remove our calls to htable.disableTable() and
> htable.enableTable() in ConnectionQueryServicesImpl when we modify the table
> metadata. The only time we still need to disable the table is before we drop
> it.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)