[ 
https://issues.apache.org/jira/browse/PHOENIX-1485?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Gabriel Reid updated PHOENIX-1485:
----------------------------------
    Attachment: PHOENIX-1485.1.patch

Thanks for taking a look [~jamestaylor]. You confirmed my understanding of the 
rules around the count of required args, but I think that this also confirms my 
thinking that there is something wrong with it :-)

Here's an updated patch with an additional fix on the count of required args, 
as well as test cases that demonstrate the various cases and show that they are 
fixed. Two of the three tests in BuiltInFunctionInfoTest fail without these 
changes in FunctionParseNode.

The issue that I was coming up against without this change to 
FunctionParseNode.BuiltInFunctionInfo was that the count of required args in 
TO_DATE was being incorrectly calculated as 2, which was then causing 
QueryCompilerTest.testNoGroupByLimitOptimization and 
QueryCompilerTest.testNotKeyOrderedGroupByOptimization to fail where TO_DATE 
was used in tests. I believe this is because the TO_DATE function was getting 
optimized out to null in these tests because the incorrect assumption was being 
made that there was a parameter without a default value that wasn't being 
supplied.

> Date columns should be displayed without timezone offset
> --------------------------------------------------------
>
>                 Key: PHOENIX-1485
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-1485
>             Project: Phoenix
>          Issue Type: Bug
>    Affects Versions: 4.1
>            Reporter: noam bulvik
>         Attachments: PHOENIX-1485.1.patch, PHOENIX-1485.patch
>
>
> when date or timestamp  column queried the value is the date with timezone 
> offset. this is not how it is handled by other jdbc drivers like oracle and 
> impala. and it seems strange that when I have text file with specific date 
> and I use bulk loader to store it , when I will use select * .. I will get 
> different dates then the one in the file (because  of the time zone offset)
> by default the date should be displayed without any offset.
> it will be nice to have an option to add the timezone offset the option in 
> the driver 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to