[
https://issues.apache.org/jira/browse/PHOENIX-1470?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14246030#comment-14246030
]
Lars Hofhansl commented on PHOENIX-1470:
----------------------------------------
I don't get it. It's failing here:
{code}
- assertFalse(cdB.getKeepDeletedCells()); // Allow KEEP_DELETED_CELLS to
be false for VEIW
+ // Allow KEEP_DELETED_CELLS to be false for VIEW
+ assertEquals(HColumnDescriptor.DEFAULT_KEEP_DELETED,
cdA.getKeepDeletedCells());
{code}
{{HColumnDescriptor.DEFAULT_KEEP_DELETED}} is false before 0.98.8 (and
KeepDeletedCell.FALSE after). How can that fail if it was not broken before?!
> KEEP_DELETED_CELLS interface changed in HBase 0.98.8
> ----------------------------------------------------
>
> Key: PHOENIX-1470
> URL: https://issues.apache.org/jira/browse/PHOENIX-1470
> Project: Phoenix
> Issue Type: Bug
> Affects Versions: 4.2
> Reporter: Jesse Yates
> Assignee: Jesse Yates
> Fix For: 5.0.0, 4.3
>
> Attachments: 1470-v2.txt, keep-deleted-cells-v1.patch,
> keep-deleted-cells.patch
>
>
> HBASE-12363 changed the contract on HColumnDescriptor#getKeepDeletedCells to
> no longer return true/false, but instead returns an enum of KeepDeletedCells.
> This seems to be fine at runtime (haven't checked) but it certainly breaks
> compilation against 0.98.8 and I don't see an obvious way of fixing it that
> is backwards compatible.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
