[ https://issues.apache.org/jira/browse/PHOENIX-1514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14250457#comment-14250457 ]
Eli Levine edited comment on PHOENIX-1514 at 12/17/14 8:21 PM: --------------------------------------------------------------- Thanks for the work, Nick! IMHO we might be better off keeping this in main and 5.0 branch. Looking at the pull req a bit... this change is quite pervasive and putting into 4.0 means version 4.3, the next minor Phoenix 4 release will get it. This is feeling like a major version feature. Keeping it in 5.0 and main might make more sense and maybe only backport it if/when people express a need for this in 4.x? was (Author: elilevine): Thanks for the work, Nick! IMHO we might be better off keeping this in main and 5.0 branch. Looking at the pull req a bit... this change is quite pervasive and putting into 4.0 means version 4.3, the next minor Phoenix 4 release will get it. This is feeling like a major version feature. Keeping it in 5.0 and main might make more sense and maybe only backport it if/when people express a need for this in 4.x. > Break up PDataType Enum > ----------------------- > > Key: PHOENIX-1514 > URL: https://issues.apache.org/jira/browse/PHOENIX-1514 > Project: Phoenix > Issue Type: Sub-task > Affects Versions: 5.0.0 > Reporter: Nick Dimiduk > Assignee: Nick Dimiduk > Fix For: 5.0.0 > > Attachments: PHOENIX-1514.00.patch, PHOENIX-1514.01.patch, > PHOENIX-1514.02.patch, PHOENIX-1514.04.patch, hung-phoenix-verify.txt, > stack.txt > > > A first step in adopting (a portion of) HBase's type encodings is to break up > the PDataType enum into an interface. This will pave the way for more > flexibility going forward. -- This message was sent by Atlassian JIRA (v6.3.4#6332)