[
https://issues.apache.org/jira/browse/PHOENIX-1541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14251953#comment-14251953
]
Nick Dimiduk commented on PHOENIX-1541:
---------------------------------------
This would have been good conversation over on PHOENIX-1514. In that patch,
have a look at PDataTypeFactory. It is through this class that the existing
logic for iterating over all registered types is implemented,
PDataTypeFactory#getTypes().
I have some ideas about using this factory to enable specific type
implementations per schema, replacing explicit use of, say {{PVarchar.INSTACE}}
with {{PDataTypeFactory.getType("VARCHAR", myTable)}}. I haven't experimented
with this yet.
> Provide common interface to find different types (reintroduce PDataType enum)
> -----------------------------------------------------------------------------
>
> Key: PHOENIX-1541
> URL: https://issues.apache.org/jira/browse/PHOENIX-1541
> Project: Phoenix
> Issue Type: Improvement
> Reporter: Dave Hacker
>
> [~jamestaylor] and I were just talking about how with the new change to
> remove PDataType enum its harder to now discover all the types the system
> supports.
> Not entirely sure what is going into the work to support the bundled HBase
> type system but It may be better to keep the enum around (have it implement
> the type interface and just delegate to the implementation class from the
> enum given the configured type system.
> [~ndimiduk] not sure what you think.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
