[
https://issues.apache.org/jira/browse/PHOENIX-1409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14265421#comment-14265421
]
Alicia Ying Shu edited comment on PHOENIX-1409 at 1/6/15 3:38 AM:
------------------------------------------------------------------
Thanks [~jamestaylor] for comments. Attached another version v5 of the patch.
Changes are:
1). Simplify TableProperty enum some more. Please see whether it looks ok to
you.
2). I had a test case in version v3 patch for "ALTER TABLE TEST_TABLE ADD col2
integer IN_MEMORY=true" and it worked in v3 patch. Did not notice it was
missing in version v4 patch (it is the side-effect of multiple-person updates).
I double checked test cases and added some more test cases on this aspect
(Alter Table Add to default column family, to existing column family, to a new
column family). The above test case
(testSetPropertyAndAddColumnForDefaultColumnFamily() in AlterTableIT.java)
failed in v4 patch because it set IN_MEMORY property to be true for all the
column families. Fixed it. Also if setting TTL instead of IN_MEMORY in above
cases, need to error out.
was (Author: aliciashu):
Thanks [~jamestaylor] for comments. Attached another version v5 of the patch.
Changes are:
1). Simplify TableProperty enum some more. Please see whether it looks ok to
you.
2). I had a test case in version v3 patch for "ALTER TABLE TEST_TABLE ADD col2
integer IN_MEMORY=true" and it worked in v3 patch. Did not notice it was
missing in version v4 patch (it is the side-effect of multiple-person updates).
I double checked test cases and added some more test cases on this aspect
(Alter Table Add to default column family, to existing column family, to a new
column family). The above test case
(testSetPropertyAndAddColumnForDefaultColumnFamily() in AlterTableIT.java)
failed in v4 patch because it set IN_MEMORY property to be true for all the
column families. Fixed it. Also if setting TTL instead of IN_MEMORY in above
case, need to error out.
> Allow ALTER TABLE <table> SET command to update HTableDescriptor and
> HColumnDescriptor properties
> -------------------------------------------------------------------------------------------------
>
> Key: PHOENIX-1409
> URL: https://issues.apache.org/jira/browse/PHOENIX-1409
> Project: Phoenix
> Issue Type: Improvement
> Affects Versions: 4.2
> Reporter: James Taylor
> Assignee: Alicia Ying Shu
> Attachments: PHOENIX-1409-v3.patch, Phoenix-1409-v1.patch,
> Phoenix-1409-v4-2.patch, Phoenix-1409-v4.patch, Phoenix-1409-v5.patch,
> Phoenix-1409.patch, WIP.patch, phoenix-1409-v2.patch
>
>
> Once PHOENIX-1408 is fixed, we should allow HTableDescriptor and
> HColumnDescriptor properties through the ALTER TABLE <table> SET command.
> It'd just be a matter of passing these properties through the existing
> methods, as we support this for CREATE TABLE.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
