[ 
https://issues.apache.org/jira/browse/PHOENIX-514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14278310#comment-14278310
 ] 

ASF GitHub Bot commented on PHOENIX-514:
----------------------------------------

Github user JamesRTaylor commented on a diff in the pull request:

    https://github.com/apache/phoenix/pull/34#discussion_r22992467
  
    --- Diff: 
phoenix-core/src/main/java/org/apache/phoenix/compile/ExpressionCompiler.java 
---
    @@ -361,7 +362,8 @@ protected ColumnRef resolveColumn(ColumnParseNode node) 
throws SQLException {
             // Disallow explicit reference to salting column, tenant ID 
column, and index ID column
             if (pkPosition >= 0) {
                 boolean isSalted = table.getBucketNum() != null;
    -            boolean isMultiTenant = context.getConnection().getTenantId() 
!= null && table.isMultiTenant();
    +            boolean isMultiTenant = context.getConnection()==null ? 
table.isMultiTenant() :
    --- End diff --
    
    When is connection null?


> Support functional indexes
> --------------------------
>
>                 Key: PHOENIX-514
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-514
>             Project: Phoenix
>          Issue Type: Task
>            Reporter: James Taylor
>            Assignee: Thomas D'Silva
>              Labels: enhancement
>
> Instead of only defining the set of columns from the data table that make up 
> an index, you should be able to use expressions.  For example:
>       CREATE INDEX upper_last_name_idx ON person (UPPER(last_name))
> Then in queries that use UPPER(last_name), we can replace them with column 
> references to the index table.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to