[ 
https://issues.apache.org/jira/browse/PHOENIX-1600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14284605#comment-14284605
 ] 

James Taylor commented on PHOENIX-1600:
---------------------------------------

Thanks for the patch, [~tedyu]. If you have a few spare cycles, [~samarthjain], 
would you mind reviewing and committing if it looks good?

> Scanner is left unclosed in MetaDataEndpointImpl#doDropTable()
> --------------------------------------------------------------
>
>                 Key: PHOENIX-1600
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-1600
>             Project: Phoenix
>          Issue Type: Bug
>            Reporter: Ted Yu
>            Assignee: Ted Yu
>            Priority: Minor
>         Attachments: phoenix-1600-001.patch
>
>
> {code}
>         RegionScanner scanner = region.getScanner(scan);
>         List<Cell> results = Lists.newArrayList();
>         scanner.next(results);
>         if (results.isEmpty()) { // Should not be possible
>             return new MetaDataMutationResult(MutationCode.TABLE_NOT_FOUND, 
> EnvironmentEdgeManager.currentTimeMillis(), null);
>         }
> {code}
> scanner is left unclosed.
> buildDeletedTable() has unclosed scanner as well.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to