Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/34#discussion_r23667770
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/index/IndexMaintainer.java ---
@@ -326,6 +326,49 @@ private IndexMaintainer(PTable dataTable, PTable
index) {
// TODO: check whether index is immutable or not. Currently it's
always false so checking
// data table is with immutable rows or not.
this.immutableRows = dataTable.isImmutableRows();
+ int indexColByteSize = 0;
+ for (int i = indexPosOffset; i < index.getPKColumns().size(); i++)
{
+ PColumn indexColumn = index.getPKColumns().get(i);
+ int indexPos = i - indexPosOffset;
+ Expression expression = null;
+ try {
+ ParseNode parseNode =
SQLParser.parseCondition(indexColumn.getExpressionStr());
--- End diff --
Will indexColumn.getExpressionStr() be null for a non functional index? If
so, instead of the instanceof check for ColumnExpression below, can we do that
here based on the null check?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
