[
https://issues.apache.org/jira/browse/PHOENIX-514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14295768#comment-14295768
]
ASF GitHub Bot commented on PHOENIX-514:
----------------------------------------
Github user twdsilva commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/34#discussion_r23719273
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/schema/MetaDataClient.java ---
@@ -2051,7 +2087,7 @@ public MutationState addColumn(AddColumnStatement
statement) throws SQLException
}
}
- boolean isAddingPKColumn = false;
+ int numPkColumnsAdded = 0;
--- End diff --
I need numPkColumnsAdded to initialize the pkColumns list later .
The boolean isAddingPKColumn can be derived from numPkColumnsAdded, so I
removed it, I can add it back using the boolean makes it more readable
// create PK column list that includes the newly created columns
List<PColumn> pkColumns =
Lists.newArrayListWithExpectedSize(table.getPKColumns().size()+numPkColumnsAdded);
> Support functional indexes
> --------------------------
>
> Key: PHOENIX-514
> URL: https://issues.apache.org/jira/browse/PHOENIX-514
> Project: Phoenix
> Issue Type: Task
> Reporter: James Taylor
> Assignee: Thomas D'Silva
> Labels: enhancement
>
> Instead of only defining the set of columns from the data table that make up
> an index, you should be able to use expressions. For example:
> CREATE INDEX upper_last_name_idx ON person (UPPER(last_name))
> Then in queries that use UPPER(last_name), we can replace them with column
> references to the index table.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
