[
https://issues.apache.org/jira/browse/PHOENIX-1610?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Maryann Xue updated PHOENIX-1610:
---------------------------------
Attachment: 1610.patch
1. Fix the push/pop problem in parser.
2. Revert shortcut for child/parent join optimization.
The initial intent of having the problematic shortcut is to avoid creation of
RVC expression objects at runtime. But this would cause wrong results in the
coercion between LHS key expression and RHS key expression (which should be a
constant RVC). So now we have to evaluate each child of RVC respectively and
construct a constant RVC expression to enclose them.
3. Since we should always coerce RHS key expression, we should not calculate
the min/max range on the initial RHS values. So we now only use "IN" expression
(previously we would construct a between/and expression in some cases according
to specific hints) and let the WhereOptimizer decide if a skip-scan or a
range-scan should be used. Thus, the hints SKIP_SCAN_HASH_JOIN and
RANGE_SCAN_HASH_JOIN are removed, but meanwhile we add
NO_CHILD_PARENT_JOIN_OPTIMIZATION to allow disabling this feature.
[~jamestaylor] Would like your comment esp. on the third item. If you agree on
the change, I will make corresponding changes in the document.
> Incorrect subquery results caused by unpaired contextStack push/pop
> -------------------------------------------------------------------
>
> Key: PHOENIX-1610
> URL: https://issues.apache.org/jira/browse/PHOENIX-1610
> Project: Phoenix
> Issue Type: Bug
> Affects Versions: 3.0.0, 4.0.0
> Reporter: Maryann Xue
> Assignee: Maryann Xue
> Fix For: 4.3, 3.3
>
> Attachments: 1610.patch
>
> Original Estimate: 24h
> Remaining Estimate: 24h
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
