[
https://issues.apache.org/jira/browse/PHOENIX-514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14302515#comment-14302515
]
ASF GitHub Bot commented on PHOENIX-514:
----------------------------------------
Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/34#discussion_r23971716
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/coprocessor/UngroupedAggregateRegionObserver.java
---
@@ -270,7 +271,7 @@ protected RegionScanner doPostScannerOpen(final
ObserverContext<RegionCoprocesso
for (IndexMaintainer maintainer :
indexMaintainers) {
if (!results.isEmpty()) {
result.getKey(ptr);
- ValueGetter valueGetter =
maintainer.createGetterFromKeyValues(results);
+ ValueGetter valueGetter =
maintainer.createGetterFromKeyValues(new
ImmutableBytesPtr(ptr).copyBytesIfNecessary(),results);
--- End diff --
Minor, but no need to create a new ImmutableBytesWritable here
> Support functional indexes
> --------------------------
>
> Key: PHOENIX-514
> URL: https://issues.apache.org/jira/browse/PHOENIX-514
> Project: Phoenix
> Issue Type: Task
> Reporter: James Taylor
> Assignee: Thomas D'Silva
> Labels: enhancement
>
> Instead of only defining the set of columns from the data table that make up
> an index, you should be able to use expressions. For example:
> CREATE INDEX upper_last_name_idx ON person (UPPER(last_name))
> Then in queries that use UPPER(last_name), we can replace them with column
> references to the index table.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)