[
https://issues.apache.org/jira/browse/PHOENIX-1641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14310368#comment-14310368
]
James Taylor commented on PHOENIX-1641:
---------------------------------------
bq. So the check oldTable.getTimeStamp() ==
MetaDataProtocol.MIN_SYSTEM_TABLE_TIMESTAMP-1 is really applicable for that
special 4.2.0 to 4.2.1 upgrade.
This was for the case where the salt byte was set (in which case the
checkAndPut would return false, since the row in the system catalog table for
SYSTEM.SEQUENCE would have already been updated), but the SYSTEM.SEQUENCE table
wasn't presplit as it should have been. So if you're coming from 4.2.1 (i.e.
based on oldTable.getTimeStamp() == MIN_SYSTEM_TABLE_TIMESTAMP_4_2_1), then I
think this is the only time you need to run this. In earlier versions, the
checkAndPut wouldn't return false and this block of code wouldn't fire, and in
later versions, the presplit would have been done.
> Make the upgrade for SYSTEM.CATALOG and SYSTEM.SEQUENCE work for 4.x to 4.3
> ---------------------------------------------------------------------------
>
> Key: PHOENIX-1641
> URL: https://issues.apache.org/jira/browse/PHOENIX-1641
> Project: Phoenix
> Issue Type: Bug
> Reporter: Samarth Jain
> Assignee: Samarth Jain
> Fix For: 5.0.0, 4.3
>
> Attachments: PHOENIX-1641.patch, PHOENIX-1641_v2.patch
>
>
> The code got removed in the commit:
> https://github.com/apache/phoenix/commit/58c80a1857659962d695bc8e5fe22b4e401b7f0a
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
