[
https://issues.apache.org/jira/browse/PHOENIX-1639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14321043#comment-14321043
]
ASF GitHub Bot commented on PHOENIX-1639:
-----------------------------------------
Github user twdsilva commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/36#discussion_r24708879
--- Diff:
phoenix-core/src/it/java/org/apache/phoenix/end2end/AlterTableIT.java ---
@@ -346,16 +347,31 @@ public void testDropCoveredColumn() throws Exception {
assertIndexExists(conn,true);
conn.createStatement().execute("ALTER TABLE " +
DATA_TABLE_FULL_NAME + " DROP COLUMN v2");
- // TODO: verify meta data that we get back to confirm our column
was dropped
assertIndexExists(conn,true);
- query = "SELECT * FROM " + DATA_TABLE_FULL_NAME;
- rs = conn.createStatement().executeQuery(query);
+ // verify data table rows
+ rs = conn.createStatement().executeQuery(dataTableQuery);
assertTrue(rs.next());
assertEquals("a",rs.getString(1));
assertEquals("x",rs.getString(2));
assertEquals("j",rs.getString(3));
assertFalse(rs.next());
+
--- End diff --
The test was not verify the index rows , so I added this.
> Enhance function/expression index tests
> ---------------------------------------
>
> Key: PHOENIX-1639
> URL: https://issues.apache.org/jira/browse/PHOENIX-1639
> Project: Phoenix
> Issue Type: Test
> Reporter: Thomas D'Silva
> Assignee: Thomas D'Silva
>
> Add tests for views, negative scenarios, sort order of expression.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
