Github user elilevine commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/37#discussion_r24846275
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/compile/UpsertCompiler.java ---
@@ -156,7 +157,7 @@ private static MutationState
upsertSelect(PhoenixStatement statement,
column.getMaxLength(), column.getScale(),
column.getSortOrder());
values[i] = ByteUtil.copyKeyBytesIfNecessary(ptr);
}
- setValues(values, pkSlotIndexes, columnIndexes, table,
mutation);
+ setValues(values, pkSlotIndexes, columnIndexes, table,
mutation, statement);
--- End diff --
It should be OK because I have separated incrementing and getting the
statement index. Incrementing should only be done by the original
statement/connection. Cloned connections should only be getting the statement
index. I think I need to do more testing here, though. Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
