[ 
https://issues.apache.org/jira/browse/PHOENIX-1489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14337026#comment-14337026
 ] 

James Taylor commented on PHOENIX-1489:
---------------------------------------

[~maryannxue] - I agree, if you can separate out the bug fix part, please check 
that into 4.0, 4.3, and master branch. For the bigger change, definitely check 
it into master. I'm still not sure I understand how it'd be backward compatible 
for the 4.0 branch in the following scenario (but I'm probably missing 
something):
- an old client executes a query like this:
{code}
SELECT a,b,c  FROM t
{code}
- the new server sends back the results in a single KeyValue instead of a 
List<KeyValue>.
- the old client uses KeyValueColumnExpression to get the value which in turn 
calls ResultTuple.getValue(cf, cq) which wouldn't find the value.


> Access column values positionally from client
> ---------------------------------------------
>
>                 Key: PHOENIX-1489
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-1489
>             Project: Phoenix
>          Issue Type: Sub-task
>            Reporter: James Taylor
>            Assignee: Maryann Xue
>         Attachments: 1489-2.patch, 1489-v1.patch, 1489-v3.patch
>
>
> Instead of passing back separate KeyValues for data returned from the server, 
> we should access via position using our TupleProjector everywhere. This is 
> already the case for joins and aggregate queries, but not for scan queries. 
> We can modify ScanRegionObserver to use our KeyValueSchema to accomplish this.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to