Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/37#discussion_r25372928
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/execute/MutationState.java ---
@@ -92,7 +100,7 @@ public MutationState(int maxSize, PhoenixConnection
connection, long sizeOffset)
this.sizeOffset = sizeOffset;
}
--- End diff --
and this (part 2 of 3):
// For tests to pass through a Map that maintains order (and keep
this.mutations as final)
public MutationState(int maxSize, PhoenixConnection connection,
Map<ImmutableBytesPtr,RowMutationState> mutations) {
this(maxSize,connection,0, mutations);
}
public MutationState(int maxSize, PhoenixConnection connection, long
sizeOffset) {
this.maxSize = maxSize;
this.connection = connection;
this.sizeOffset = sizeOffset;
this.mutations = Maps.newHashMapWithExpectedSize(3); // TODO: size
based on something else as this is a bad default
}
public MutationState(int maxSize, PhoenixConnection connection, long
sizeOffset, Map<ImmutableBytesPtr,RowMutationState> mutations) {
this.maxSize = maxSize;
this.connection = connection;
this.sizeOffset = sizeOffset;
this.mutations = mutations;
}
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
