[ https://issues.apache.org/jira/browse/PHOENIX-1115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14338948#comment-14338948 ]
Samarth Jain commented on PHOENIX-1115: --------------------------------------- [~rajeshbabu] couple of questions: 1) I see that we start a new span when trace is turned on. Should the span be stopped when trace is turned off? This way the span associated with the turning tracing on/off operation will end up showing in the trace table too. 2) In the close() method of the ResultIterator returned by TraceQueryPlan, should we be executing the same code that is executed when we turn trace off. What would happen if the user turns trace on, executes queries/mutations and just closes the connection without calling TRACE OFF? > Provide a SQL command to turn tracing on/off > -------------------------------------------- > > Key: PHOENIX-1115 > URL: https://issues.apache.org/jira/browse/PHOENIX-1115 > Project: Phoenix > Issue Type: Sub-task > Reporter: James Taylor > Assignee: Rajeshbabu Chintaguntla > Fix For: 5.0.0 > > Attachments: PHOENIX-1115.patch, PHOENIX-1115_v2.patch, > PHOENIX-1115_v3.patch, PHOENIX-1115_v4.patch, Screen Shot 2014-11-21 at > 3.41.41 PM.png, tracing_in_different_rdbms.pdf > > > Provide a SQL command that turns tracing on and off. For example, Oracle has > this: > {code} > ALTER SESSION SET sql_trace = true; > ALTER SESSION SET sql_trace = false; > {code} > We might consider allowing the sampling rate to be set as well. -- This message was sent by Atlassian JIRA (v6.3.4#6332)