[
https://issues.apache.org/jira/browse/PHOENIX-1060?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14351430#comment-14351430
]
Samarth Jain commented on PHOENIX-1060:
---------------------------------------
[~jamestaylor], [~rajeshbabu] - Looking at the changes, it seems like this is
something that should be put on 4.4 and master. Let me know if you strongly
feel that this should be part of our next patch release 4.3.1 .
> Replace ReferencingColumn with ColumnReference
> ----------------------------------------------
>
> Key: PHOENIX-1060
> URL: https://issues.apache.org/jira/browse/PHOENIX-1060
> Project: Phoenix
> Issue Type: Sub-task
> Reporter: rajeshbabu
> Assignee: Rajeshbabu Chintaguntla
> Priority: Minor
> Fix For: 5.0.0, 4.3.1
>
> Attachments: PHOENIX-1060.patch, PHOENIX-1060_v2.patch
>
>
> We currently have two separate classes that represent a column family/column
> qualifier combo: ColumnReference and ReferencingColumn. I believe the only
> difference is that ReferencingColumn allows a backing byte array to be used
> with an offset and length. Since ColumnReference already has an
> ImmutableBytesPtr we can add a constructor that takes two offsets and lengths
> for the family and qualifier and do a bit of minor refactoring (removing the
> family and qualifier member variables and just use the familyPtr and
> qualifierPtr ones exclusivly) so that we don't have two classes for the same
> thing:
> {code}
> public class ColumnReference implements Comparable<ColumnReference> {
>
> public ColumnReference(byte[] family, int familyOffset, int familyLength,
> byte[] qualifier, int qualifierOffset, int qualiferLength) {
> this.familyPtr = new ImmutableBytesPtr(family, familyOffset,
> familyLength);
> this.qualifierPtr = new ImmutableBytesPtr(qualifier, qualifierOffset,
> qualifierLength);
> this.hashCode = calcHashCode(familyPtr.get(), qualifierPtr.get());
> }
> {code}
> Another useful addition would be to implement Writable so we don't duplicate
> the serialization logic.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
