Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/41#discussion_r26189030
--- Diff: phoenix-assembly/pom.xml ---
@@ -20,131 +20,139 @@
-->
-<project xmlns="http://maven.apache.org/POM/4.0.0";
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
- xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
http://maven.apache.org/xsd/maven-4.0.0.xsd";>
- <modelVersion>4.0.0</modelVersion>
- <parent>
- <groupId>org.apache.phoenix</groupId>
- <artifactId>phoenix</artifactId>
- <version>5.0.0-SNAPSHOT</version>
- </parent>
- <artifactId>phoenix-assembly</artifactId>
- <name>Phoenix Assembly</name>
- <description>Assemble Phoenix artifacts</description>
- <packaging>pom</packaging>
+<project xmlns="http://maven.apache.org/POM/4.0.0";
+ xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
+ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
http://maven.apache.org/xsd/maven-4.0.0.xsd";>
+ <modelVersion>4.0.0</modelVersion>
+ <parent>
+ <groupId>org.apache.phoenix</groupId>
+ <artifactId>phoenix</artifactId>
+ <version>5.0.0-SNAPSHOT</version>
+ </parent>
+ <artifactId>phoenix-assembly</artifactId>
+ <name>Phoenix Assembly</name>
+ <description>Assemble Phoenix artifacts</description>
+ <packaging>pom</packaging>
- <build>
- <plugins>
- <plugin>
- <artifactId>maven-assembly-plugin</artifactId>
- <executions>
- <execution>
- <id>client</id>
- <phase>package</phase>
- <goals>
- <goal>single</goal>
- </goals>
- <configuration>
- <attach>false</attach>
- <finalName>phoenix-${project.version}</finalName>
- <archive>
- <index>true</index>
- <manifest>
- <addClasspath>true</addClasspath>
-
<addDefaultImplementationEntries>true</addDefaultImplementationEntries>
-
<addDefaultSpecificationEntries>true</addDefaultSpecificationEntries>
- </manifest>
- </archive>
- <descriptors>
- <descriptor>src/build/client.xml</descriptor>
- </descriptors>
- </configuration>
- </execution>
- <execution>
- <id>package-to-tar</id>
- <phase>package</phase>
- <goals>
- <goal>single</goal>
- </goals>
- <configuration>
- <finalName>phoenix-${project.version}</finalName>
- <attach>false</attach>
- <tarLongFileMode>gnu</tarLongFileMode>
- <appendAssemblyId>false</appendAssemblyId>
- <descriptors>
- <descriptor>src/build/package-to-tar-all.xml</descriptor>
- </descriptors>
- <tarLongFileMode>posix</tarLongFileMode>
- </configuration>
- </execution>
- <execution>
- <id>package-to-source-tar</id>
- <phase>package</phase>
- <goals>
- <goal>single</goal>
- </goals>
- <configuration>
- <finalName>phoenix-${project.version}-source</finalName>
- <attach>false</attach>
- <tarLongFileMode>gnu</tarLongFileMode>
- <appendAssemblyId>false</appendAssemblyId>
- <descriptors>
- <descriptor>src/build/src.xml</descriptor>
- </descriptors>
- <tarLongFileMode>posix</tarLongFileMode>
- </configuration>
- </execution>
- <execution>
- <id>client-minimal</id>
- <phase>package</phase>
- <goals>
- <goal>single</goal>
- </goals>
- <configuration>
- <finalName>phoenix-${project.version}</finalName>
- <attach>false</attach>
- <appendAssemblyId>true</appendAssemblyId>
- <descriptors>
- <!--build the phoenix client jar, but without HBase code.
-->
- <descriptor>src/build/client-without-hbase.xml</descriptor>
- <!-- build the phoenix client jar, but without HBase (or
its depenencies). -->
- <descriptor>src/build/client-minimal.xml</descriptor>
- <!-- build the phoenix server side jar, that includes
phoenix-hadoopX-compat, phoenix-hadoop-compat and antlr -->
- <descriptor>src/build/server.xml</descriptor>
- <!-- build the phoenix server side jar, that includes
phoenix-hadoopX-compat and phoenix-hadoop-compat. -->
- <descriptor>src/build/server-without-antlr.xml</descriptor>
- </descriptors>
- </configuration>
- </execution>
- </executions>
- </plugin>
- <!-- No jars created for this module -->
- <plugin>
- <groupId>org.apache.maven.plugins</groupId>
- <artifactId>maven-jar-plugin</artifactId>
- <executions>
- <execution>
- <phase>prepare-package</phase>
- <goals />
- </execution>
- </executions>
- </plugin>
- </plugins>
- </build>
+ <build>
+ <plugins>
+ <plugin>
+ <artifactId>maven-assembly-plugin</artifactId>
+ <executions>
+ <execution>
+ <id>client</id>
+ <phase>package</phase>
+ <goals>
+ <goal>single</goal>
+ </goals>
+ <configuration>
+ <attach>false</attach>
+
<finalName>phoenix-${project.version}</finalName>
+ <archive>
+ <index>true</index>
+ <manifest>
+ <addClasspath>true</addClasspath>
+ <addDefaultImplementationEntries>true
+ </addDefaultImplementationEntries>
+ <addDefaultSpecificationEntries>true
+ </addDefaultSpecificationEntries>
+ </manifest>
+ </archive>
+ <descriptors>
+
<descriptor>src/build/client.xml</descriptor>
+ </descriptors>
+ </configuration>
+ </execution>
+ <execution>
+ <id>package-to-tar</id>
+ <phase>package</phase>
+ <goals>
+ <goal>single</goal>
+ </goals>
+ <configuration>
+
<finalName>phoenix-${project.version}</finalName>
+ <attach>false</attach>
+ <tarLongFileMode>gnu</tarLongFileMode>
+ <appendAssemblyId>false</appendAssemblyId>
+ <descriptors>
+
<descriptor>src/build/package-to-tar-all.xml</descriptor>
+ </descriptors>
+ <tarLongFileMode>posix</tarLongFileMode>
+ </configuration>
+ </execution>
+ <execution>
+ <id>package-to-source-tar</id>
+ <phase>package</phase>
+ <goals>
+ <goal>single</goal>
+ </goals>
+ <configuration>
+
<finalName>phoenix-${project.version}-source</finalName>
+ <attach>false</attach>
+ <tarLongFileMode>gnu</tarLongFileMode>
+ <appendAssemblyId>false</appendAssemblyId>
+ <descriptors>
+ <descriptor>src/build/src.xml</descriptor>
+ </descriptors>
+ <tarLongFileMode>posix</tarLongFileMode>
+ </configuration>
+ </execution>
+ <execution>
+ <id>client-minimal</id>
+ <phase>package</phase>
+ <goals>
+ <goal>single</goal>
+ </goals>
+ <configuration>
+
<finalName>phoenix-${project.version}</finalName>
+ <attach>false</attach>
+ <appendAssemblyId>true</appendAssemblyId>
+ <descriptors>
+ <!--build the phoenix client jar, but
without HBase code. -->
+
<descriptor>src/build/client-without-hbase.xml</descriptor>
+ <!-- build the phoenix client jar, but
without HBase (or its depenencies). -->
+
<descriptor>src/build/client-minimal.xml</descriptor>
+ <!-- build the phoenix server side jar,
that includes phoenix-hadoopX-compat, phoenix-hadoop-compat and antlr -->
+
<descriptor>src/build/server.xml</descriptor>
+ <!-- build the phoenix server side jar,
that includes phoenix-hadoopX-compat and phoenix-hadoop-compat. -->
+
<descriptor>src/build/server-without-antlr.xml</descriptor>
+ </descriptors>
+ </configuration>
+ </execution>
+ </executions>
+ </plugin>
+ <!-- No jars created for this module -->
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-jar-plugin</artifactId>
+ <executions>
+ <execution>
+ <phase>prepare-package</phase>
+ <goals/>
+ </execution>
+ </executions>
+ </plugin>
+ </plugins>
+ </build>
- <dependencies>
- <!-- Depend on all other internal projects -->
- <dependency>
- <groupId>org.apache.phoenix</groupId>
- <artifactId>phoenix-core</artifactId>
- </dependency>
- <dependency>
- <groupId>org.apache.phoenix</groupId>
- <artifactId>phoenix-flume</artifactId>
- </dependency>
+ <dependencies>
+ <!-- Depend on all other internal projects -->
<dependency>
- <groupId>org.apache.phoenix</groupId>
- <artifactId>phoenix-pig</artifactId>
- </dependency>
- </dependencies>
+ <groupId>org.apache.phoenix</groupId>
+ <artifactId>phoenix-core</artifactId>
+ </dependency>
+ <dependency>
+ <groupId>org.apache.phoenix</groupId>
+ <artifactId>phoenix-flume</artifactId>
+ </dependency>
+ <dependency>
+ <groupId>org.apache.phoenix</groupId>
+ <artifactId>phoenix-pig</artifactId>
+ </dependency>
+ <!--<dependency>-->
--- End diff --
Remove comment?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
