[
https://issues.apache.org/jira/browse/PHOENIX-1653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14357166#comment-14357166
]
Gabriel Reid commented on PHOENIX-1653:
---------------------------------------
This looks like a really good improvement [~gjacoby]. There are just a few
items I noticed:
* There are two methods in PhoenixConfigurationUtil (getBatchSize and
getUpsertColumnMetadataList) that are using ConnectionUtil.getInputConnection,
but I think they should be using ConnectionUtil.getOutputConnection (because
both methods are based around settings for writing data)
* The name of ConnectionUtil.getOutputConnection currently contains a typo
(it's getOuptutConnection in the code right now)
* minor nit: ConnectionUtil.getInputConnection and
ConnectionUtil.getOutputConnection have verbatim copies of the same
configuration-to-properties method code, would be good if this is extracted
into a method
* really minor nit: the testInputClusterOverride and testOutputClusterOverride
methods in PhoenixConfigurationUtilTest use a Phoenix JDBC url (the return
value of getUrl()) as the "default" quorum value, and use "localhost" as the
override. It would probably be better to change this to two fake quorum
strings, as the return value of getUrl() isn't a quorum string, and "localhost"
is the HBase default used for the quorum if there isn't one supplied. Nothing
functionally wrong with the test as is, but using actual non-default quorum
strings will make the intent of these tests more clear.
> Allow option to pass peer zookeeper address to load data into a target
> cluster in Map Reduce api
> ------------------------------------------------------------------------------------------------
>
> Key: PHOENIX-1653
> URL: https://issues.apache.org/jira/browse/PHOENIX-1653
> Project: Phoenix
> Issue Type: Improvement
> Affects Versions: 5.0.0
> Reporter: maghamravikiran
> Labels: newbie, patch
> Attachments: PHOENIX-1653.patch, PHOENIX-1653v2.patch
>
>
> Provide an option to pass the peer zookeeper address within a MapReduce job
> where PhoenixInputFormat reads from one HBase cluster, and
> PhoenixOutputFormat writes to a different cluster.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
