Github user JamesRTaylor commented on the pull request:
https://github.com/apache/phoenix/pull/45#issuecomment-78853991
@shuxiong - you're doing a great job so far. Just revert SignFunction back
to your original version, keep the PWholeNumber and PRealNumber classes you
created but make signum polymorphic, and throw an exception in the case of NaN
for double (though I don't think it's possible for that to occur in Phoenix),
and you'll be done with this one and ready to move on to other bigger issues.
Appreciate your work here.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
