[
https://issues.apache.org/jira/browse/PHOENIX-1715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14360069#comment-14360069
]
ASF GitHub Bot commented on PHOENIX-1715:
-----------------------------------------
Github user JamesRTaylor commented on the pull request:
https://github.com/apache/phoenix/pull/45#issuecomment-78853991
@shuxiong - you're doing a great job so far. Just revert SignFunction back
to your original version, keep the PWholeNumber and PRealNumber classes you
created but make signum polymorphic, and throw an exception in the case of NaN
for double (though I don't think it's possible for that to occur in Phoenix),
and you'll be done with this one and ready to move on to other bigger issues.
Appreciate your work here.
> Implement Build-in math function Sign
> -------------------------------------
>
> Key: PHOENIX-1715
> URL: https://issues.apache.org/jira/browse/PHOENIX-1715
> Project: Phoenix
> Issue Type: Sub-task
> Reporter: Shuxiong Ye
> Assignee: Shuxiong Ye
>
> Take a look at the typical math functions that are implemented in relational
> database systems
> (http://www.postgresql.org/docs/current/static/functions-math.html) and
> implement the same for Phoenix in Java following this guide:
> http://phoenix-hbase.blogspot.com/2013/04/how-to-add-your-own-built-in-function.html
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
