Github user JamesRTaylor commented on a diff in the pull request:

    https://github.com/apache/phoenix/pull/38#discussion_r26443330
  
    --- Diff: phoenix-core/src/it/java/org/apache/phoenix/end2end/QueryIT.java 
---
    @@ -295,6 +299,130 @@ public void testTimestamp() throws Exception {
         }
         
         @Test
    +    public void testDateBetweenLiterals() throws Exception {
    --- End diff --
    
    Tests look good, but let's put them in a new class derived from 
BaseHBaseManagedTimeIT as we're trying to move away from tests that manage the 
timestamp through the CURRENT_SCN since it's much less common than just letting 
HBase manage the timestamps. It's also easier to write your test, because you 
can just open a single connection and do everything on it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to