Github user shuxiong commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/46#discussion_r26670082
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/expression/LikeExpression.java ---
@@ -289,8 +288,11 @@ public boolean evaluate(Tuple tuple,
ImmutableBytesWritable ptr) {
return true;
}
- String value = (String) PVarchar.INSTANCE.toObject(ptr,
getStrExpression().getSortOrder());
- boolean matched = pattern.matcher(value).matches();
+ String value = null;
+ if (logger.isDebugEnabled()) {
+ value = (String) PVarchar.INSTANCE.toObject(ptr,
getStrExpression().getSortOrder());
--- End diff --
1. The original code has debugging lines, so I try to remains them. We just
turn ptr into String when debugs.
2. I don't quite understand what "rename getStrExpression()" means here?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
