Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/46#discussion_r26684109
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/expression/visitor/CloneExpressionVisitor.java
---
@@ -107,7 +109,9 @@ public Expression visitLeave(ComparisonExpression node,
List<Expression> l) {
@Override
public Expression visitLeave(LikeExpression node, List<Expression> l) {
- return Determinism.PER_INVOCATION.compareTo(node.getDeterminism())
> 0 ? node : new LikeExpression(l);
--- End diff --
No instanceof checks. Add an abstract clone method to LikeExpression and
call that here instead.
abstract public LikeExpression clone(List<Expression> children);
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
