[
https://issues.apache.org/jira/browse/PHOENIX-1705?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dumindu Buddhika updated PHOENIX-1705:
--------------------------------------
Attachment: PHOENIX-1705_implement_ARRAY_APPEND_built_in_function7.patch
Thanks for the feedback [~jamestaylor] and [~ram_krish].
Extra pointer created(elementPtr) is removed.
Sorry for the println calls. Removed them(I tend to forget to remove them :p).
Code formatted.
[~jamestaylor]
Here if I just return true here it won't be pointed to the input array(which is
not the expected behavior) and the function will return null. So I evaluated
the arrayExpression and then returned its result. Then the function will return
the input array itself. I hope its the way to go about that.
{quote}
For your evaluate function, return true immediately if the element to be
appended is null, as we don't store trailing nulls in an array.
{quote}
New patch.
> implement ARRAY_APPEND built in function
> ----------------------------------------
>
> Key: PHOENIX-1705
> URL: https://issues.apache.org/jira/browse/PHOENIX-1705
> Project: Phoenix
> Issue Type: Sub-task
> Reporter: Dumindu Buddhika
> Assignee: Dumindu Buddhika
> Attachments:
> PHOENIX-1705_implement_ARRAY_APPEND_built_in_function.patch,
> PHOENIX-1705_implement_ARRAY_APPEND_built_in_function.patch,
> PHOENIX-1705_implement_ARRAY_APPEND_built_in_function1.patch,
> PHOENIX-1705_implement_ARRAY_APPEND_built_in_function2.patch,
> PHOENIX-1705_implement_ARRAY_APPEND_built_in_function3.patch,
> PHOENIX-1705_implement_ARRAY_APPEND_built_in_function4.patch,
> PHOENIX-1705_implement_ARRAY_APPEND_built_in_function5.patch,
> PHOENIX-1705_implement_ARRAY_APPEND_built_in_function6.patch,
> PHOENIX-1705_implement_ARRAY_APPEND_built_in_function7.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
