[ 
https://issues.apache.org/jira/browse/PHOENIX-1580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14386062#comment-14386062
 ] 

Alicia Ying Shu commented on PHOENIX-1580:
------------------------------------------

[~jamestaylor], [~maryannxue]: Uploaded a patch for UnionAll after 
incorporating grammar changes. The modifications include:

1. Removed the isUnion boolean from SelectStatement constructor.
2. Throw a new SQLException if UNION is done inside of a subquery.
3. Add more tests - test bind variables within the sub selects; Union all in 
subqueries.
4. I did not get MergeSortTopNResultIterator work so still used 
OrderedResultIterator if there's an ORDER BY in UnionPlan. Please take a look 
of this. 
5. Tested partial implementation of PHOENIX-1749 for order by by positions. It 
worked for Union all. It is a separate issue. I will work on that shortly after 
Union all. 
Thanks.




> Support UNION ALL
> -----------------
>
>                 Key: PHOENIX-1580
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-1580
>             Project: Phoenix
>          Issue Type: Bug
>            Reporter: Alicia Ying Shu
>            Assignee: Alicia Ying Shu
>         Attachments: PHOENIX-1580-grammar.patch, Phoenix-1580-v1.patch, 
> phoenix-1580-v1-wipe.patch, phoenix-1580.patch, unionall-wipe.patch
>
>
> Select * from T1
> UNION ALL
> Select * from T2



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to