[ https://issues.apache.org/jira/browse/PHOENIX-1712?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14389245#comment-14389245 ]
ASF GitHub Bot commented on PHOENIX-1712: ----------------------------------------- Github user gabrielreid commented on the pull request: https://github.com/apache/phoenix/pull/47#issuecomment-88218650 Looks good, and I think that the test cases cover what needs to be covered. Could you rebase the patch on the master branch, and squash the commits into a single commit? If you're not familiar with how to do this, just let me know and I'll do it when I commit the code. > Implementing INSTR function > --------------------------- > > Key: PHOENIX-1712 > URL: https://issues.apache.org/jira/browse/PHOENIX-1712 > Project: Phoenix > Issue Type: Sub-task > Reporter: Naveen Madhire > Assignee: Naveen Madhire > Priority: Minor > Original Estimate: 40h > Remaining Estimate: 40h > > This is sub-task to implement a custom INSTR function just like in Oracle. -- This message was sent by Atlassian JIRA (v6.3.4#6332)