[
https://issues.apache.org/jira/browse/PHOENIX-1580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14391631#comment-14391631
]
Alicia Ying Shu edited comment on PHOENIX-1580 at 4/1/15 11:00 PM:
-------------------------------------------------------------------
[~maryannxue] After applying your patch, almost all of my tests failed with
NPE. The NPE was from ParseNodeRewriter.java. So I added the following in
ParseNodeRewriter.java. Does it look ok?
if (from == null)
return statement;
Also many existing tests failed. Those all passed before your patch. Looks like
ParameterCount gave us trouble again. Also got a lot of NULL result back. Can
you work on it if you think it is better later. I have clearly stated many
database systems do not wrap UNION ALL with dummy select *.
I have made all the changes asked by [~jamestaylor]
was (Author: aliciashu):
[~maryannxue] After applying your patch, almost all of my tests failed with
NPE. The NPE was from ParseNodeRewriter.java. So I added the following in
ParseNodeRewriter.java. Does it look ok?
if (from == null)
return statement;
Also many existing tests failed. Those all passed before your patch. Looks like
ParameterCount gave us trouble again. Also got a lot of NULL result back. Still
not clear what the additional select wrapping gains us. Can we make my patch
without the additional select wrapping? You can always work on it if you think
it is better later. I have clearly stated many database systems do not wrap
UNION ALL with dummy select *.
I have made all the changes asked by [~jamestaylor]
> Support UNION ALL
> -----------------
>
> Key: PHOENIX-1580
> URL: https://issues.apache.org/jira/browse/PHOENIX-1580
> Project: Phoenix
> Issue Type: Bug
> Reporter: Alicia Ying Shu
> Assignee: Alicia Ying Shu
> Attachments: PHOENIX-1580-grammar.patch, Phoenix-1580-v1.patch,
> Phoenix-1580-v2.patch, Phoenix-1580-v3.patch, phoenix-1580-v1-wipe.patch,
> phoenix-1580.patch, unionall-wipe.patch
>
>
> Select * from T1
> UNION ALL
> Select * from T2
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
