[
https://issues.apache.org/jira/browse/PHOENIX-1580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14392232#comment-14392232
]
Alicia Ying Shu commented on PHOENIX-1580:
------------------------------------------
[~jamestaylor] Thanks a lot for the comments. To confirm a couple of issues.
1. >Implement getTableRef() as returning either null or by returning a static
final constant TableRef for union. Seems like you wouldn't need to pass this
through the constructor as it doesn't seem like it would ever be different.
The TableRef here is the temp schema TableRef. It will be passed in from
constructor.
2. As for UnionPlan.explain(). My understanding is that it would get all the
steps involved and return an ExplanPlan object, which will be used in
PhoenixStatement. So I need to loop through all the subPlans to get the steps
and include OrderBy and Limit. While explain(List<String> planSteps) in
UnionResultIterators is to get the explain for that particular iterator, i.e
PeekingResultIterator. I tested Explain in my unit tests, it seemed it worked
as the way I implemented.
> Support UNION ALL
> -----------------
>
> Key: PHOENIX-1580
> URL: https://issues.apache.org/jira/browse/PHOENIX-1580
> Project: Phoenix
> Issue Type: Bug
> Reporter: Alicia Ying Shu
> Assignee: Alicia Ying Shu
> Attachments: PHOENIX-1580-grammar.patch, Phoenix-1580-v1.patch,
> Phoenix-1580-v2.patch, Phoenix-1580-v3.patch, Phoenix-1580-v4.patch,
> Phoenix-1580-v5.patch, phoenix-1580-v1-wipe.patch, phoenix-1580.patch,
> unionall-wipe.patch
>
>
> Select * from T1
> UNION ALL
> Select * from T2
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
