[ https://issues.apache.org/jira/browse/PHOENIX-971?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14393267#comment-14393267 ]
Gabriel Reid commented on PHOENIX-971: -------------------------------------- That is really cool [~ndimiduk]! I'm really surprised by how little code is required to make that all work. It all looks good to me so far. I've just taken a quick pass over it and tried it out, and things seem to be working. A few minor points that I could make: * the python scripts should probably exit with the status code of the java command (the other scripts were recently updated to do this as well) * I think that the environment variable used for finding the HBase configuration is typically HBASE_CONF_DIR, and not HBASE_CONF_PATH * maybe the naming of the driver and it's module should include the word "thin", it might make things a bit more clear in the future * I saw that sqlline is a dependency in the driver module, with a TODO about the bin scripts being the issue. Am I correct in assuming that this can be fully resolved just within one of the python scripts? > Query server > ------------ > > Key: PHOENIX-971 > URL: https://issues.apache.org/jira/browse/PHOENIX-971 > Project: Phoenix > Issue Type: New Feature > Reporter: Andrew Purtell > Assignee: Nick Dimiduk > Fix For: 5.0.0 > > Attachments: PHOENIX-971.00.patch, image-2.png > > > Host the JDBC driver in a query server process that can be deployed as a > middle tier between lighter weight clients and Phoenix+HBase. This would > serve a similar optional role in Phoenix deployments as the > [HiveServer2|https://cwiki.apache.org/confluence/display/Hive/Setting+Up+HiveServer2] > does in Hive deploys. -- This message was sent by Atlassian JIRA (v6.3.4#6332)