[ https://issues.apache.org/jira/browse/PHOENIX-1580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14394921#comment-14394921 ]
Alicia Ying Shu edited comment on PHOENIX-1580 at 4/3/15 7:13 PM: ------------------------------------------------------------------ [~jamestaylor] Appreciate your review. I am at the same boat. 1. I used a way to explain plan before which gave correct results. I was asked to change to use different method. The extra steps came from existing explain plans afterwards. I can fix it as you said. 2. I already said without checking NULL, tests failed with NPE. 3. I got confused about Maryann's comments about SQLUnsupportedException. I can definitely put those back. was (Author: aliciashu): [~jamestaylor] Appreciate your review. I am at the same boat. 1. I used a way to explain plan before which gave correct results. I was asked to changed to use different method. The extra steps came from existing explain plans afterwards. I can fix it as you said. 2. I already said without checking NULL, tests failed with NPE. 3. I got confused about Maryann's comments about SQLUnsupportedException. I can definitely put those back. > Support UNION ALL > ----------------- > > Key: PHOENIX-1580 > URL: https://issues.apache.org/jira/browse/PHOENIX-1580 > Project: Phoenix > Issue Type: Improvement > Reporter: Alicia Ying Shu > Assignee: Alicia Ying Shu > Attachments: PHOENIX-1580-grammar.patch, Phoenix-1580-v1.patch, > Phoenix-1580-v2.patch, Phoenix-1580-v3.patch, Phoenix-1580-v4.patch, > Phoenix-1580-v5.patch, Phoenix-1580-v6.patch, Phoenix-1580-v7.patch, > Phoenix-1580-v8.patch, phoenix-1580-v1-wipe.patch, phoenix-1580.patch, > unionall-wipe.patch > > > Select * from T1 > UNION ALL > Select * from T2 -- This message was sent by Atlassian JIRA (v6.3.4#6332)